test(conway): add checks for future pparams query #3170
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkoura
commented
Oct 29, 2025
| pparams = state.get("curPParams") or state.get("currentPParams") or {} | ||
| pparams = state.get("curPParams") or state.get("currentPParams") or state or {} | ||
| clusterlib_utils.check_updated_params( | ||
| update_proposals=fin_update_proposals, protocol_params=pparams |
Collaborator
Author
There was a problem hiding this comment.
We already have this clusterlib_utils.check_updated_params function for comparing pparams dict with update proposal. We can re-use it also for checking future pparams query output.
mkoura
force-pushed
the
check_future_pparams_example
branch
from
11de572 to
f3cf774
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.